add unsafe_set!(::Textbox, ::String) #4417
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjarthur
force-pushed
the
bja/fixtextbox
branch
2 times, most recently
from
5c6d019 to
e30ba7b
Compare
bjarthur
changed the title
|
ready for review! |
bjarthur
changed the title
bjarthur
force-pushed
the
bja/fixtextbox
branch
from
e30ba7b to
4f43ad3
Compare
bjarthur
force-pushed
the
bja/fixtextbox
branch
from
4f43ad3 to
24fd6c4
Compare
|
Was there any reason not to merge this? |
|
note that i have since changed the UI in the app of mine that needed this. others might find |
|
not sure why the tests are failing. the errors don't seem to be related to this PR. plus some of these which do not have textboxes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
a return value of
nothingis clearly wrong for this do-block as the lifted observable is a Tuple of Points.i came across this error when manually setting
displayed_stringin an app of mine.happy to add a test if someone suggests how to do so.EDIT: a 2nd commit now adds an unexported
unsafe_set!, which like the extantset!method sets thedisplayed_stringbut does not throw an exception if the string does not pass the validator function. the use case is to highlight the portion of the string that does not pass the validator by replacing it with the invalid portion. was the most simple UI for an app of mine.Type of change
Delete options that do not apply:
Checklist